Skip to content

ARM Router #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

ARM Router #142

wants to merge 57 commits into from

Conversation

@clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Oct 31, 2025

Description

Create a Router for ARM.

clement-ux and others added 30 commits October 31, 2025 11:50
@clement-ux
wip: poc for ARM router
5027a1d
@clement-ux
feat: add swapExactETHForTokens function and WETH initialization
4e55b29
@clement-ux
feat: add swapExactTokensForTokensSimple function for simplified toke…
9949660 
…n swaps
@clement-ux
wip
89fade6
@clement-ux
clean up
6754a15
@clement-ux
add first tests
7d3c57d
@clement-ux
add Router to gas report
af06875
@clement-ux
improve global logic
f559162
@clement-ux
Add swap functionality and tests for ARMRouter
2bfec2b 
- Introduced SwapType enum for distinguishing between ARM and Wrapper swaps.
- Implemented swapTokensForExactTokens function in ARMRouter.
- Updated internal swap logic to handle exact token swaps.
- Created unit tests for swapTokensForExactTokens functionality.
- Enhanced MockWrapper with functions for price queries.
- Updated shared test setup to register new configurations.
@clement-ux
add ETH swaps
5764008
@clement-ux
update .gitignore and Makefile to include snapshots in clean targets;…
6422dae 
… enable gas snapshot check in foundry.toml
@clement-ux
reduce error message length
81d3f82
@clement-ux
Add fork test for Router
baeb1c9
@clement-ux
fmt
6d5a812
@clement-ux
Add return values for swap functions in AbstractARM contract
8aec020
@clement-ux
Add UpgradeEtherFiARMScript and update DeployManager to include it
944c414
@clement-ux
try to fix
2c88e22
@clement-ux
Increase verbosity of non-invariant tests output in CI workflow
7374240
@clement-ux
try again
a182d00
@clement-ux
Reduce verbosity of non-invariant tests output in CI workflow
bf6bbe5
@clement-ux
improve CIs
3b8121e
@clement-ux
pause some tests
4204daf
@clement-ux
Add test targets for unit, fork, and smoke tests command
eb35cdb
@clement-ux
Add return values to swap functions in AbstractARM contract documenta…
34b311b 
…tion
@clement-ux
Disable gas snapshot check in foundry.toml
443f722
@clement-ux
Fix rounding error in amountIn calculation by adding 1 after decoding
e2268c7
@clement-ux
Rename swap functions for clarity and update parameters in Router tests
0bdc135
@naddison36
Merge remote-tracking branch 'origin/main' into clement/add-returns
6d3cdf2
@naddison36
Add return amounts to swap interfaces with no path
ae5cc7c
@clement-ux
Merge branch 'main' into clement/router
b05ad6b
@clement-ux clement-ux marked this pull request as ready for review November 4, 2025 09:01
naddison36
naddison36 reviewed Nov 5, 2025
View reviewed changes
naddison36
naddison36 reviewed Nov 5, 2025
View reviewed changes
@clement-ux
Optimize swap logic by caching next token index to reduce gas costs i…
2122204 
…n ARMRouter
@clement-ux
Optimize gas usage by caching length minus two in swap function of AR…
767e3d6 
…MRouter
@clement-ux
Optimize gas usage in _swapsForExactTokens by caching path length and…
241fa58 
… next token index
@clement-ux
Optimize gas usage in _getAmountsIn and swap loop by caching path len…
ccb8ae5 
…gths and next token indices
@clement-ux
Optimize gas usage in swap function by caching last index of path and…
0cd5e4d 
… amounts
@clement-ux
Optimize gas usage in swap function by caching the first amount for i…
c39d263 
…nput checks and deposits
@clement-ux
Optimize gas usage in swap functions by caching amounts and path lengths
5cf186e
@clement-ux
Optimize gas usage in swap function by caching path length and token …
d2ac0c5 
…addresses
@clement-ux
Optimize gas usage in swap functions by caching last index calculatio…
16697e1 
…ns and adjusting input checks
@clement-ux
Get gas consumption for functions call on tests.
87b15f7
@clement-ux
Copy link
Contributor Author

clement-ux commented Nov 5, 2025 •
edited
Loading

Comment on Gas-Golfing

Here is the gas-reduction report from gas-golfing session:
Comparison between commit fe5e0fc and 87b15f7
DiffChecker:https://github.com/OriginProtocol/arm-oeth/compare/fe5e0fc..87b15f7

ExactTokensForTokens

image

TokensForExactTokens

image

Conclusion

I average this is a -0.3% of gas consumption. This is good, but this comes at the expense of code smoothness. Does it makes sense to keep these changes @naddison36?

@clement-ux
Copy link
Contributor Author

clement-ux commented Nov 7, 2025 •
edited
Loading

Gas Optimization Reduction Summary

Overview

This report compares Initial vs Final gas costs across various swap operations. All values represent reductions (negative numbers indicate cost decreases).

Detailed Breakdown

Operation Initial Final Reduction % Change
ETHForExactTokens: EETH 104,345 102,735 -1,610 -1.54%
ExactETHForTokens: EETH 92,711 91,513 -1,198 -1.29%
ExactTokensForETH: EETH 128,592 126,906 -1,686 -1.31%
ExactTokensForTokens: Bypass Router: EETH_WETH 46,739 46,303 -436 -0.93%
ExactTokensForTokens: EETH_WETH 83,120 81,819 -1,301 -1.56%
ExactTokensForTokens: WEETH_WETH 108,774 107,050 -1,724 -1.59%
ExactTokensForTokens: WEETH_WSTETH 277,719 274,333 -3,386 -1.22%
ExactTokensForTokens: WETH_EETH 80,753 79,518 -1,235 -1.53%
ExactTokensForTokens: WETH_WEETH 189,946 187,924 -2,022 -1.06%
ExactTokensForTokens: WSTETH_WEETH 277,719 274,333 -3,386 -1.22%
TokensForExactETH: EETH 133,209 131,089 -2,120 -1.59%
TokensForExactTokens: Bypass Router: EETH_WETH 46,858 46,398 -460 -0.98%
TokensForExactTokens: EETH_WETH 87,759 86,052 -1,707 -1.94%
TokensForExactTokens: WEETH_WETH 115,851 113,441 -2,410 -2.08%
TokensForExactTokens: WEETH_WSTETH 291,247 286,829 -4,418 -1.52%
TokensForExactTokens: WETH_EETH 85,273 83,677 -1,596 -1.87%
TokensForExactTokens: WETH_WEETH 196,776 194,240 -2,536 -1.29%
TokensForExactTokens: WSTETH_WEETH 291,202 286,784 -4,418 -1.52%

Summary Statistics

  • Average Reduction per Operation: -2,236 units
  • Average Percentage Reduction: -1.43%
  • Largest Single Reduction: -4,418 units (WEETH_WSTETH operations)
  • Smallest Single Reduction: -436 units (Bypass Router: EETH_WETH)

Note:

  • Reduction on tests Bypass Router correspond to reduction obtained thanks to increasing optimizor_runs from 200 to 50000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naddison36 naddison36 naddison36 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clement-ux @naddison36